All Questions

Community

D
Gonsen

missing underscore to _is_open

There is a typo in the code at the section Having the GUI open the machine GUI, _is_open is missing the underscore.

The following code:

    # If the inventory window is already open, we close it first. This ensures
    # we close any currently opened gui from another entity first.
    if is_open:
        _close_inventories()

Should be:

    # If the inventory window is already open, we close it first. This ensures
    # we close any currently opened gui from another entity first.
    if _is_open:
        _close_inventories()

Oh! I just realized that in the reference code this typo is everywhere, I guess the underscore was added in later versions of the course.

  • Nathan Lovato replied

    Thanks, will fix it today

  • Nathan Lovato replied

    It should actually be the opposite, seems there was a change to make this property public instead of pseudo-private, probably when working on the third chapter of this complex project. I'll update previous lessons to have is_open everywhere.

  • D
    Gonsen replied

    Yes in the 2nd part Simulation game: the Inventory _is_open are all with underscore. I didn't realize the 3rd part and the final project is without. Makes sense to make it public though since we access it from other scripts.

    Thanks.

  • Nathan Lovato replied

    Thank you for reporting all the typos and inconsistencies! I updated the course yesterday. Now it's is_open everywhere.

  • D
    Gonsen replied

    You're welcome! Thank you and all your team for the courses!